[Calypso] Commands failing with git identity error message

[Guido Günther]

Hi,
On Fri, Jul 28, 2017 at 09:51:35AM +0100, Roger Bell_West wrote:
> On Fri, Jul 28, 2017 at 10:25:00AM +0200, Guido Günther wrote:
> >Not that I know of. Can you run calypso with --debug and post some more
> >output (or send it to me in private mail if you don't want this on a
> >mailing list)?
> 
> OK, here's a run with debug, starting just before the point where I
> tried to delete an item:
> 
> 10.0.155.246 - - [28/Jul/2017 09:40:37] "REPORT /private/roger-public/ HTTP/1.1" 207 -
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in collection: /private/roger-public
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in collection: /private/roger-public
> owner private user roger
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in name: 19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in collection: /private/roger-public
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in collection: /private/roger-public
> Path /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics results in name: 19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics
> Remove object 19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics
> Remove 19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics
> rm 'cal-g6yKvD.ics'
> ['git', '-c', 'advice.implicitIdentity=false', 'commit', '-m', 'Remove old file\n\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Lightning/5.4.2.1']
> 
> *** Please tell me who you are.
> 
> Run
> 
>   git config --global user.email "you at example.com"
>   git config --global user.name "Your Name"
> 
> to set your account's default identity.
> Omit --global to set the identity only in this repository.
> 
> fatal: empty ident name (for <infobot at dayspring.homenet.firedrake.org>) not allowed
> Failed to remove /home/infobot/.config/calypso/calendars/private/roger-public/cal-g6yKvD.ics
> Traceback (most recent call last):
>   File "/home/infobot/calypso/calypso/webdav.py", line 354, in destroy_file
>     self.git_rm(item.path, context=context)
>   File "/home/infobot/calypso/calypso/webdav.py", line 309, in git_rm
>     self.git_commit("Remove old file", context=context)
>   File "/home/infobot/calypso/calypso/webdav.py", line 299, in git_commit
>     subprocess.check_call(args, cwd=self.path, env=env)
>   File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> CalledProcessError: Command '['git', '-c', 'advice.implicitIdentity=false', 'commit', '-m', 'Remove old file\n\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Lightning/5.4.2.1']' returned non-zero exit status 128
> 10.0.155.246 - - [28/Jul/2017 09:40:57] "DELETE /private/roger-public/19fa1218-37c2-493c-ae8b-54ac93e84cf5.ics HTTP/1.1" 204 -
> 
> (This doesn't generate an error in the client, but there are
> uncommited changes in the git repo.)
> 
> However, I've just noticed that I've been running an old version from
> the keithp repo, and the Debian/jessie version 1.4 doesn't suffer from
> this problem. It does still have lots of SSL timeouts across a LAN,
> but I think I can blame Thunderbird for that; the other programs I use
> to talk to Calypso don't have that problem.

I was about to ask for the used version. Glad it works now.
 -- Guido