[Calypso] Incorrect parsing of rrule?

Guido G√ľnther agx at sigxcpu.org
Sun Jan 31 04:04:24 PST 2016


Hi,
[..snip..]
> @@ -357,8 +370,15 @@ def report(path, xml_request, collection):
>  
>          
>          for item in items:
> -            if not match_filter(item, filter_element):
> -                continue
> +            try:
> +                if not match_filter(item, filter_element):
> +                    continue
> +            except ValueError as e:
> +                # FIXME figure out how to pass e.msg to client
> +                response = ET.Element(_tag("D", "response"))
> +                multistatus.append(response)
> +                status.text = _response(client.BAD_REQUEST)
> +                pass
>  
>              response = ET.Element(_tag("D", "response"))
>              multistatus.append(response)

We'd have multistatus.append(response) twice then. So until this is
sorted out I've applied your original version and added a follow with
parts of this version to raise ValueError and test for that in the
testsuite so we at least fail the whole request correctly for now.

Tested with IceOwl.

Cheers,
 -- Guido


More information about the Calypso mailing list