[Calypso] [PATCH] Remove DURATION if both DURATION and DTEND are present on a VEVENT.

Petter Reinholdtsen pere at hungry.com
Wed Jan 27 15:19:29 PST 2016


[Jelmer Vernooij]
> From: Jelmer Vernooń≥ <jelmer at jelmer.uk>
>
> See RFC5545, section 3.6.1.

So I guess the current implementation is wrong.  Perhaps that should be
mentioned in the commit message?  This look like a definite improvement
to the current incorrect implementation.

Also, given that the RFC states "Either 'dtend' or 'duration' MAY appear
in a 'eventprop', but 'dtend' and 'duration' MUST NOT occur in the same
'eventprop'", perhaps we should reject such entries with an error
instead of silently accept it and remove the duration?  Or at least log
an error with id and prodid to make it possible to know that it
happened?

> @@ -528,7 +533,7 @@ class Collection(object):
>          except Exception, ex:
>              self.log.exception("Failed to import: %s", path)
>              return False
> -        
> +
>      def write(self, headers=None, items=None):
>          return True
>  

Should this whitespace change be included in this patch?

-- 
Happy hacking
Petter Reinholdtsen


More information about the Calypso mailing list