[Calypso] Incorrect parsing of rrule?

Petter Reinholdtsen pere at hungry.com
Mon Jan 25 01:42:55 PST 2016


[Guido G√ľnther]
> Wouldn't it be simpler to exercise match_filter_element() directly
> (introducing a new unit test class TestMatchFIlterElement). You'd then
> have tight control on the input data and the matching rules. The
> necessary data could be dumped out of match_filter_element() with the
> unpatched code.

Yes, this was simpler.  Using match_filter() I got a working test.  In
the process I discovered that the test probably worked earlier too, as
the query was for VTODO items while the test set had VCALENDAR an item.
Anyway, attached are two patches to fix the handling of <time-range>.
The first is just making the type of a return value more consistent,
while the second actually fixes the issue.

-- 
Happy hacking
Petter Reinholdtsen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-sure-match_filter-return-True-or-False-not-True.patch
Type: text/x-diff
Size: 811 bytes
Desc: not available
URL: <http://keithp.com/pipermail/calypso/attachments/20160125/0a1d780f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Allow-time-range-query-filters-to-be-open-ended.patch
Type: text/x-diff
Size: 7416 bytes
Desc: not available
URL: <http://keithp.com/pipermail/calypso/attachments/20160125/0a1d780f/attachment-0001.patch>


More information about the Calypso mailing list