[Calypso] [PATCH] Also catch ValueError when attempting to parse rrulset.
agx at sigxcpu.org
Wed Apr 6 11:00:10 PDT 2016
On Wed, Apr 06, 2016 at 09:24:03AM +0100, Jelmer Vernooij wrote:
> This happens if there is no = sign in rruleset, which happens with davdroid for me.
Ack if you put this into the commit message.
> On 6 April 2016 07:57:37 BST, "Guido Günther" <agx at sigxcpu.org> wrote:
> >Hi Jelmer,
> >On Tue, Apr 05, 2016 at 08:08:27PM +0000, Jelmer Vernooij wrote:
> >> From: Jelmer Vernooĳ <jelmer at jelmer.uk>
> >> ---
> >> calypso/xmlutils.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> diff --git a/calypso/xmlutils.py b/calypso/xmlutils.py
> >> index b9f728a..fef802f 100644
> >> --- a/calypso/xmlutils.py
> >> +++ b/calypso/xmlutils.py
> >> @@ -272,7 +272,7 @@ def match_filter_element(vobject, fe):
> >> elif fe.tag == _tag("C", "time-range"):
> >> try:
> >> rruleset = vobject.rruleset
> >> - except AttributeError:
> >> + except (AttributeError, ValueError):
> >> return False
> >> start = fe.get("start")
> >> end = fe.get("end")
> >Any details why this needs to be catched. Do you have a trace that we
> >could add to the commit message?
> > -- Guido
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
More information about the Calypso